Skip to content

Fix waveform_display plot

Luca Scotto Lavina requested to merge github/fork/cheryonthetop/yingfan_branch into master

Created by: cheryonthetop

The pull request addresses issue #135 (closed) by changing the order of the layout in the returned value of waveform_display function. I also added a title "Time vs Channel" which is previously non-existent to the plot. The code being changed is essentially:

 layout = (time_v_channel + peak_wvs 
              + array_plot['top'] +  array_plot['bottom'])
layout = time_v_channel + peak_wvs + array_plot['top'] + array_plot['bottom']

The file being changed is holoviews_waveform_display, which is entirely based on pull request #128 which provides a fix for the plot in the first place. The new time vs channel plot is now correct and looks like below:

bokeh_plot (5)

Why does changing the order of the layout address an issue related to y-axis of a plot? Not entirely sure, the question is rather: why does holoviews layout reconfigure your plot when the plot is in a certain order, which causes the weird issue that is #135 (closed).

Merge request reports