Skip to content

HE veto length clipped at chunk end time

Luca Scotto Lavina requested to merge github/fork/sophiaandaloro/master into master

Created by: sophiaandaloro

What is the problem / what does the code in this PR do Software HE veto helps veto tails of large peaks to reduce unneeded data. The duration of this veto should be a configurable setting, which defaults to the end of the chunk if the length is larger than the chunk length.

The issue is that the length is clipped at the end of records length right now, which is not always the same as the chunk endtime.

Can you briefly describe how it works? np.clip used to clip values above chunk endtime.

Can you give a minimal working example (or illustrate with a figure)?

    veto_end = np.clip(peaks['time'] + veto_length,
                       None,
                       chunk_end)

will return peaks['time'] + veto_length or chunk_end time, whichever is smaller.

Please include the following if applicable:

  • Update the docstring(s) DONE
  • Update the documentation DONE
  • Tests to check the (new) code is working as desired. TESTING WITH PR
  • Does it solve one of the open issues on github? NO (but I refrained from opening one just to solve it!)

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

Merge request reports